[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v2 3/6] x86/P2M: simplify write_p2m_entry()



>>> On 24.04.14 at 18:00, <tim@xxxxxxx> wrote:
> At 13:30 +0100 on 22 Apr (1398169800), Jan Beulich wrote:
>> The "table_mfn" parameter really isn't needed anywhere, so it gets
>> dropped.
>> 
>> The "struct vcpu *" one was always bogus (as was being made up by
>> paging_write_p2m_entry()), and is not commonly used. It can be easily
>> enough made up in the one place (sh_unshadow_for_p2m_change()) it is
>> needed, and we can otherwise pass "struct domain *" instead, properly
>> reflecting that P2M operations are per-domain.
>> 
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> 
> Reviewed-by: Tim Deegan <tim@xxxxxxx>
> 
> and I think should be applicable independent of the rest of the
> series.

Yes indeed, all that is required is that it precedes the NPT patches. I
guess I'll commit it some time tomorrow unless you tell me otherwise.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.