Re: [Xen-devel] [PATCH v4 12/21] xen/passthrough: iommu: Split generic IOMMU code

[Julien Grall <julien.grall@xxxxxxxxxx>]

Hi Jan,

On 04/22/2014 02:48 PM, Jan Beulich wrote:
>>>> On 22.04.14 at 15:14, <julien.grall@xxxxxxxxxx> wrote:
>> The generic IOMMU framework code (xen/drivers/passthrough/iommu.c) contains
>> functions specific to x86 and PCI.
>>
>> Split the framework in 3 distincts files:
>>     - iommu.c: contains generic functions shared between x86 and ARM
>>                (when it will be supported)
>>     - pci.c: contains specific functions for PCI passthrough
>>     - x86/iommu.c: contains specific functions for x86
>>
>> io.c contains x86 HVM specific code. Only compile for x86.
>>
>> This patch is mostly code movement in new files.
>>
>> Signed-off-by: Julien Grall <julien.grall@xxxxxxxxxx>
> 
> Acked-by: Jan Beulich <jbeulich@xxxxxxxx>

Thanks. To answer to your other mail, I didn't modify the behavior of
the functions, only split them.

> if one minor inconsistency gets addressed:

>> +void __hwdom_init arch_iommu_check_hwdom_reqs(struct domain *d)
>> +{
>> +    if ( !iommu_enabled )
>> +        panic("Presently, iommu must be enabled for pvh dom0\n");
>> +}
> 
> Message text (containing PVH) and function name (not containing
> PVH) don't fit together, nor does the conditional really establish a
> connection.

Do you prefer a comment, or an explicit check to is_pvh_domain(d)?

Regards,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel