Re: [Xen-devel] [PATCH v8 1/3] xen/libxc: Allow changing max number of hypervisor cpuid leaves

[Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>]

On 04/22/2014 05:45 AM, Jan Beulich wrote:
> > > > On 21.04.14 at 23:57, <boris.ostrovsky@xxxxxxxxxx> wrote:
> > +    if ( (limit < 2) || (limit > XEN_CPUID_MAX_NUM_LEAVES) )
> > +        limit = XEN_CPUID_MAX_NUM_LEAVES;
> Almost: If limit < 2, you would be better off using 2 rather than the
> default (which may be growing).
My thinking was that for any invalid limit value we should ignore what 
the user file specified, not try to guess what was meant.
-boris

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel