Re: [Xen-devel] [PATCH RFC 04/23] libxc: add support for FreeBSD

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Ian Campbell writes ("Re: [PATCH RFC 04/23] libxc: add support for FreeBSD"):
> On Thu, 2014-04-17 at 17:30 +0100, Ian Jackson wrote:
> > > +    /* Discard from the buffer cache. */
> > > +    if ( posix_fadvise(fd, 0, cur, POSIX_FADV_DONTNEED) < 0 )
> > > +        goto out;
> > 
> > Which also means that the use of posix_fadvise is hardly safe.
> > fadvise can quite legally be a noop.
> 
> I think that's ok, it's for "reducing the impact on dom0" not
> correctness, according to the commit which added it:

Oh, good.  Thanks for digging that up.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel