Re: [Xen-devel] [PATCH v3 13/16] xen/arm: Add support for GIC v3

[Julien Grall <julien.grall@xxxxxxxxxx>]

On 04/17/2014 08:09 AM, Vijay Kilari wrote:
>>> +                if ( typer & GICR_TYPER_VLPIS )
>>> +                    ptr += SZ_64K * 2; /* Skip VLPI_base + reserved page */
>>> +            }
>>> +        } while ( !(typer & GICR_TYPER_LAST) );
>>> +    }
>>> +
>>> +    dprintk(XENLOG_WARNING, "CPU%d: mpidr %"PRIpaddr" has no 
>>> re-distributor!\n",
>>> +                  smp_processor_id(), mpidr);
>>
>> What happen if you don't have re-distributor?
>>
>   I think, we can't handle SGI & PPI's. As configuration and handling of these
> is done in GICR region. May be I can change it to BUG_ON

Please, no BUG_ON. As I said previously, you have to propagate the error
code. It will be useful for CPU hotplug later.

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel