Re: [Xen-devel] [PATCH v1 6/6] x86/tools: Expose SMAP to HVM guests

["Wu, Feng" <feng.wu@xxxxxxxxx>]

> -----Original Message-----
> From: Ian Campbell [mailto:Ian.Campbell@xxxxxxxxxx]
> Sent: Tuesday, April 15, 2014 5:20 PM
> To: Wu, Feng
> Cc: JBeulich@xxxxxxxx; xen-devel@xxxxxxxxxxxxx; Nakajima, Jun; Dong, Eddie
> Subject: Re: [PATCH v1 6/6] x86/tools: Expose SMAP to HVM guests
> 
> Please could you arrange for your series posting to be threaded, i.e.
> emails {1..6}/6 should be replies to 0/6. This is very helpful to
> reviewers etc since it keeps everything together. I thought this was the
> default mode of git send-email...
> 

Sorry for that, the series were threaded, but I made a mistake in series [0/6] 
and [3/6], so
I sent these two again.

> On Tue, 2014-04-15 at 21:02 +0800, Feng Wu wrote:
> > This patch exposes SMAP festure to HVM guests
> >
> > Signed-off-by: Feng Wu <feng.wu@xxxxxxxxx>
> 
> Assuming that the hypervisor guys agree that this makes sense the
> implementation here is trivially correct:
> Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> 
> > ---
> >  tools/libxc/xc_cpufeature.h | 1 +
> >  tools/libxc/xc_cpuid_x86.c  | 1 +
> >  2 files changed, 2 insertions(+)
> >
> > diff --git a/tools/libxc/xc_cpufeature.h b/tools/libxc/xc_cpufeature.h
> > index c464e3a..37c69f7 100644
> > --- a/tools/libxc/xc_cpufeature.h
> > +++ b/tools/libxc/xc_cpufeature.h
> > @@ -137,5 +137,6 @@
> >  #define X86_FEATURE_ERMS         9 /* Enhanced REP MOVSB/STOSB
> */
> >  #define X86_FEATURE_INVPCID     10 /* Invalidate Process Context ID
> */
> >  #define X86_FEATURE_RTM         11 /* Restricted Transactional
> Memory */
> > +#define X86_FEATURE_SMAP        20 /* Supervisor Mode Access
> Protection */
> >
> >  #endif /* __LIBXC_CPUFEATURE_H */
> > diff --git a/tools/libxc/xc_cpuid_x86.c b/tools/libxc/xc_cpuid_x86.c
> > index bbbf9b8..953945f 100644
> > --- a/tools/libxc/xc_cpuid_x86.c
> > +++ b/tools/libxc/xc_cpuid_x86.c
> > @@ -367,6 +367,7 @@ static void xc_cpuid_hvm_policy(
> >                          bitmaskof(X86_FEATURE_HLE)  |
> >                          bitmaskof(X86_FEATURE_AVX2) |
> >                          bitmaskof(X86_FEATURE_SMEP) |
> > +                        bitmaskof(X86_FEATURE_SMAP) |
> >                          bitmaskof(X86_FEATURE_BMI2) |
> >                          bitmaskof(X86_FEATURE_ERMS) |
> >                          bitmaskof(X86_FEATURE_INVPCID) |
> 

Thanks,
Feng
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel