Re: [Xen-devel] [PATCH v1 5/6] VMX: Disable SMAP feature when guest is in non-paging mode

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 15.04.14 at 15:02, <feng.wu@xxxxxxxxx> wrote:
> SMAP is disabled if CPU is in non-paging mode in hardware.
> However Xen always uses paging mode to emulate guest non-paging
> mode with HAP. To emulate this behavior, SMAP needs to be manually
> disabled when guest switches to non-paging mode.
> 
> This logic is similiar with SMEP.

The change is certainly fine, but shouldn't this be done earlier in the
series (i.e. the patch moved up)?

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel