Re: [Xen-devel] [PATCH v1 2/6] x86: Temporary disable SMAP to legally access user pages in kernel mode

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 15.04.14 at 12:21, <andrew.cooper3@xxxxxxxxxx> wrote:
> On 15/04/14 14:01, Feng Wu wrote:
>> @@ -985,7 +995,9 @@ int __init construct_dom0(
>>      }
>>      BUG_ON(pfn != d->tot_pages);
>>  #ifndef NDEBUG
>> +    stac();
>>      alloc_epfn += PFN_UP(initrd_len) + si->nr_p2m_frames;
>> +    clac();
> 
> This could presumably be eliminated by keeping a stack copy of
> si->nr_p2m_frames ?

That'll go away together with everything else here in favor of
construct_dom0() as a whole getting wrapped in a stac()/clac()
part (as suggested by Kevin).

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel