Re: [Xen-devel] [PATCH RFC 4/9] libxl_internal: introduce libxl__json_object_is_{null, number, double}

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2014-04-15 at 10:29 +0100, Wei Liu wrote:
> On Mon, Apr 14, 2014 at 06:04:27PM +0100, Ian Campbell wrote:
> > On Thu, 2014-04-10 at 16:40 +0100, Wei Liu wrote:
> > > ... which return true if json object is valid and of type
> > > JSON_{NULL,NUMBER,DOUBLE}.
> > > 
> > > Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> > 
> > Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> > 
> > But... 
> > > +static inline bool libxl__json_object_is_null(const libxl__json_object 
> > > *o)
> > > +{
> > > +    return o != NULL && o->type == JSON_NULL;
> > 
> > Shouldn't these (new and existing) use the bit field stuff you just
> > introduced?
> > 
> 
> No, [...]

Makes sense, thanks for the explanation.

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel