Re: [Xen-devel] [PATCH 2/2] ts-debian-hvm-install: fix guest memory size

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Wei Liu writes ("[PATCH 2/2] ts-debian-hvm-install: fix guest memory size"):
> Change the default memory size to 768MB, which is taken from
> ts-redhat-install. It should be a safe size to make this test case run
> on every host.
...
> -our $ram_mb=   6000;
> +our $ram_mb=    768;
>  our $disk_mb= 10000;
>  
>  our $guesthost= "$gn.guest.osstest";
> @@ -166,6 +166,14 @@ sub prep () {
>      });
>  }
>  
> +# If host has >5G free memory, create a guest with 5G memory to catch any 
> error
> +# that triggers cross 4G boundary
> +our $host_freemem_mb = host_get_free_memory($ho, $toolstack);
> +if ($host_freemem_mb > 5000) {
> +    $ram_mb = 5000;

If the host has exactly 5000, this will result in failure.

Also I don't like the separation of the two values for $ram_mb.  The
manifest constant at the top of the script is misleading given that
the code might override it.  I think you probably want to bury the
magic constant(s) in with the setting code.

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel