Re: [Xen-devel] [PATCH v4 8/8] ioreq-server: bring the PCI hotplug controller implementation into Xen

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 09.04.14 at 16:25, <Paul.Durrant@xxxxxxxxxx> wrote:
>> From: Jan Beulich [mailto:JBeulich@xxxxxxxx]
>> >>> On 09.04.14 at 15:42, <Paul.Durrant@xxxxxxxxxx> wrote:
>> > Personally I find using forward jumps to fail labels the most readable form
>> > of error exit - I wish they were used more widely.
>> 
>> Interesting - almost everyone/-thing involved in educating me in
>> programming skills recommended to try to get away without goto
>> altogether, unless programming Fortran, Basic or some such.
>> 
> 
> In my case it comes from programming for SPARC where forward branches were 
> (are?) statically predicted untaken, so much better to code your error path 
> as a single forward branch. Don't have to worry about such things for x86, 
> but I'm used to reading code that looks like that :-/

The static prediction rules are similar on x86, but there's no guarantee
that what is a forward branch at the source level would end up being
one in the translated code. That's what we've got likely()/unlikely() for.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel