Re: [Xen-devel] [PATCH v2 09/15] xen/arm: segregate VGIC low level functionality

[Julien Grall <julien.grall@xxxxxxxxxx>]

Hello Vijay,

Thank you for the patch.

On 04/04/2014 12:56 PM, vijay.kilari@xxxxxxxxx wrote:
> From: Vijaya Kumar K <Vijaya.Kumar@xxxxxxxxxxxxxxxxxx>
> 
> VGIC low level functionality is segregated into
> separate functions and are called using registered
> callback wherever required.
> 
> This helps to separate generic and hardware functionality
> later

Same remark as patch #5, is less clear to have 2 separate patches.

[..]

> +DT_DEVICE_START(gicv2, "VGIC", DEVICE_VGIC)
> +        .compatible = vgicv2_dt_compat,
> +        .init = vgic_v2_init,
> +DT_DEVICE_END
> +

hrm ... VGIC is not a device, if you don't plan to support different
VGIC per domain then you can directly return the vgic callbacks for the
gic drivers.

Regards,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel