Re: [Xen-devel] [PATCH V4 02/12] TestSupport.pm: introduce create_iso_xorriso for creating isos

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Wei Liu writes ("Re: [PATCH V4 02/12] TestSupport.pm: introduce 
create_iso_xorriso for creating isos"):
> On Wed, Apr 02, 2014 at 05:01:00PM +0100, Ian Jackson wrote:
> > Wei Liu writes ("[PATCH V4 02/12] TestSupport.pm: introduce 
> > create_iso_xorriso for creating isos"):
> > > ... and convert ts-redhat-install to make use of it.
> > 
> > Thanks:
> > 
> > > +
> > > +                      create_iso_xorriso
> > 
> > Why the additional blank line ?
> 
> To separate this function from other category. More functions will come.

Ah, OK.

> I will also rename this function to iso_* according to your suggestion
> on later patch.

Thanks.

> > > -    my @isogen_base= qw(-R -J -T);
> > > +    my @isogen_base= qw(-as mkisofs -R -J);
> > 
> > I haven't checked these xorriso options; I'll take your word for them.
> > 
> 
> For genisoimage:
> -R     Generate SUSP and RR records using the Rock Ridge protocol to
>        further describe the files on the ISO9660 filesystem.
> -J     Generate Joliet directory records in addition to regular ISO9660
>        filenames.
> -T     Generate  a  file  TRANS.TBL  in each directory on the CD-ROM,
>        which can be used on non-Rock Ridge-capable systems to
>        help establish the correct filenames.
> 
> For xorriso with mkisofs personality:
> -R    same as above (taken from man 8 mkisofs)
> -J    same as above (taken from man 8 mkisofs)
> -T    same as above, but will be ignored by xorriso

Great, thanks.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel