Re: [Xen-devel] [PATCH V4 06/12] TestSupport.pm: introduce create_empty_iso

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Wed, Apr 02, 2014 at 05:08:04PM +0100, Ian Jackson wrote:
> Wei Liu writes ("[PATCH V4 06/12] TestSupport.pm: introduce 
> create_empty_iso"):
> > Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> ...
> > +sub create_empty_iso($$$) {
> > +    my ($ho,$emptyiso,$emptydir) = @_;
> > +    my @isogen_opts= qw(-as mkisofs -R -J);
> > +
> > +    # Unfortunately xorriso refuses to create an ISO if the input
> > +    # directory is empty.
> 
> How annoying.
> 

With the help of a Xorriso developer this problem is fixed.

> > +    target_cmd_root($ho, <<END, 60);
> > +        mkdir -p $emptydir
> > +        echo empty > $emptydir/empty
> > +END
> 
> Isn't this a duplicate of the code in ts-redhat-install ?
> 

This will be deleted in my next version.

Wei.

> Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel