[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v10 2/6] x86: dynamically attach/detach CQM service for a guest



>>> On 26.03.14 at 07:35, <dongxiao.xu@xxxxxxxxx> wrote:
> --- a/xen/include/public/domctl.h
> +++ b/xen/include/public/domctl.h
> @@ -896,6 +896,14 @@ struct xen_domctl_cacheflush {
>  typedef struct xen_domctl_cacheflush xen_domctl_cacheflush_t;
>  DEFINE_XEN_GUEST_HANDLE(xen_domctl_cacheflush_t);
>  
> +struct xen_domctl_qos_type {
> +#define _XEN_DOMCTL_pqos_cqm      0
> +#define XEN_DOMCTL_pqos_cqm       (1U<<_XEN_DOMCTL_pqos_cqm)
> +    uint64_t flags;

Can you remind me again why this is a flag rather than (for now)
a single enumerator (not necessarily implemented via enum, but
from the perspective of its meaning)?

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.