Re: [Xen-devel] [PATCH v5 05/10] xen/arm: nr_lrs should be uint8_t

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2014-04-01 at 13:12 +0100, Julien Grall wrote:
> On 04/01/2014 12:59 PM, Ian Campbell wrote:
> > On Mon, 2014-03-24 at 18:49 +0000, Stefano Stabellini wrote:
> >> Signed-off-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
> > 
> > Does this change anything in practice?
> 
> Patch #6 of Stefano's series keep track of LRs with an uint8 bits. I
> asked for this patch to stupid issue later because the tracking use an
> smaller number of bits.

I wish that sort of thing would be mentioned in commit messages.

> 
> > Hopefully the compiler doesn't start doing stupid word access + mask on
> > every access...
> > 
> > Might there be more LRs with e.g. gic v3?
> 
> The number of LRs is encoded on 5 bits for the GICv3.
> 



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel