[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 6/8] x86/EPT: force re?evaluation of memory type as necessary



>>> On 26.03.14 at 18:18, <andreslc@xxxxxxxxxxxxxx> wrote:
>> +void p2m_memory_type_changed(struct domain *d)
>> +{
>> +    struct p2m_domain *p2m = p2m_get_hostp2m(d);
>> +
>> +    if ( p2m->memory_type_changed )
>> +    {
>> +        p2m_lock(p2m);
>> +        p2m->memory_type_changed(p2m);
> I don't see the memory_type_changed function pointer for p2m-pt.c.
> 
> It might not be needed immediately, but it's a little land-mine waiting to be 
> NULL-dereferenced.

Not sure what you're trying to tell me here - the deref is in an if()
checking the pointer to be non-NULL.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.