Re: [Xen-devel] [RFC PATCH v1 08/10] xen/arm: Add support for GIC v3

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Sat, 2014-03-22 at 15:37 +0530, Vijay Kilari wrote:

> >> +/* Wait for completion of a distributor change */
> >> +static void gic_do_wait_for_rwp(paddr_t base)
> >> +{
> >> +    u32 val;
> >> +    do {
> >> +        val = readl_relaxed((void *)base + GICD_CTLR);
> >> +        val = readl_relaxed(GICD + GICD_CTLR);

Are these both required for some reason? Looks like the second might be
a left over from a previous iteration?

> >> +        val = GICD[GICD_CTLR];
> >> +        cpu_relax();
> >> +    } while (val & GICD_CTLR_RWP);
> >> +}
> >

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel