Re: [Xen-devel] [RFC PATCH v1 10/10] xen/arm: GICv3 device tree parsing

[Vijay Kilari <vijay.kilari@xxxxxxxxx>]

Hi,

 Julien,

On Thu, Mar 20, 2014 at 9:38 PM, Julien Grall <julien.grall@xxxxxxxxxx> wrote:
> Hello Vijay,
>
> Thanks for the patch. I think the name of this patch is wrong. You are
> not parsing the device tree but creating the node for DOM0.
>
OK

> On 03/19/2014 02:17 PM, vijay.kilari@xxxxxxxxx wrote:
>> From: Vijaya Kumar K <Vijaya.Kumar@xxxxxxxxxxxxxxxxxx>
>>
>> GICv3 supports system register access to GIC cpu interface.
>> So no need to read device tree for cpu interface.
>> GICv3 adds Re-distributor region and redistributor stride
>> which are parsed.
>
> If I understand correctly, DOM0 kernel must support GICv3, right? What
> about booting DOM0 with only GICv2 support, e.g. because the kernel is
> only using less than 8 CPUs?
>
Yes, correct.
If DOM0 supports only V2, then Xen should load vgic v2 driver?
if so, how to detect it?

> [..]
>
>> +    if (hw_type == GIC_VERSION_V3)
>> +    {
>> +        res = dt_property_read_u32(gic, "redistributor-stride", &rd_stride);
>> +        if ( !res )
>> +            rd_stride = 0;
>> +    }
>
> Actually I would prefer if you introduce an callback to create these new
> property.
>
OK. you mean callback of driver should be called from here

> Regards,
>
> --
> Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel