Re: [Xen-devel] [RFC PATCH v1 04/10] arm/xen: move gic save and restore registers to gic driver

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2014-03-20 at 15:22 +0000, Julien Grall wrote:
> > @@ -98,6 +105,9 @@ irq_desc_t *__irq_to_desc(int irq)
> >  void gic_save_state(struct vcpu *v)
> >  {
> >      int i;
> > +    struct gic_state_data *d;
> > +    d = (struct gic_state_data *)v->arch.gic_state;
> > +
> 
> You don't need the cast. Can you also rename d in state? Using d is very
> confusing as it's a common alias used for domain.

Yes, I was about to query how it was correct to move all this per-vcpu
state into a per-domain structure.

I don't think accessing this as v->arch.gic_state->gic_apr etc would be
the end of the world, although in context it seems like the field could
become just apr and even s/gic_state/gic/ I think. Everything in struct
vcpu_info is state.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel