Re: [Xen-devel] [PATCH 10/17] xen: arm64: disable alignment traps

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 20/03/14 15:45, Ian Campbell wrote:
> The mem* primitives which I am about to import from Linux in a subsequent
> patch rely on the hardware handling misalignment.
>
> The benefits of an optimised memcpy etc oughtweigh the downsides.
>
> Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> ---
>  xen/arch/arm/arm64/head.S |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/xen/arch/arm/arm64/head.S b/xen/arch/arm/arm64/head.S
> index 9547ef5..22d0030 100644
> --- a/xen/arch/arm/arm64/head.S
> +++ b/xen/arch/arm/arm64/head.S
> @@ -241,7 +241,7 @@ skip_bss:
>           * I-cache enabled,
>           * Alignment checking enabled,

Is this comment still true?

~Andrew

>           * MMU translation disabled (for now). */
> -        ldr   x0, =(HSCTLR_BASE|SCTLR_A)
> +        ldr   x0, =(HSCTLR_BASE)
>          msr   SCTLR_EL2, x0
>  
>          /* Rebuild the boot pagetable's first-level entries. The structure


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel