Re: [Xen-devel] [PATCH v4 1/4] xen/libxc: Allow changes to hypervisor CPUID leaf from config file

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 17.03.14 at 21:22, Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx> wrote:
> +static void xc_cpuid_constrain(const unsigned int *input, unsigned int *regs,
> +    unsigned int *polregs, char **config_transformed)
> +{
> +    unsigned int i;
> +
> +    if ( IS_HYPERVISOR_LEAF(input[0]) )
> +    {
> +        switch ( input[0] )
> +        {
> +            case 0x40000000:

I thought you know that special casing this leaf alone doesn't
suffice, because of cpuid_hypervisor_leaves() having

    uint32_t base = is_viridian_domain(d) ? 0x40000100 : 0x40000000;

i.e. I'd suggest "switch ( input[0] & 0xff )" etc.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel