Re: [Xen-devel] xen-mfndump xch bug (was Re: New Defects reported by Coverity Scan for XenProject)

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 13/03/14 17:19, Dario Faggioli wrote:
> On gio, 2014-03-13 at 17:05 +0000, Ian Jackson wrote:
>> scan-admin@xxxxxxxxxxxx writes ("New Defects reported by Coverity Scan for XenProject"):
>> ___________________________
>>> *** CID 1191885: Dereference after null check (FORWARD_NULL)
>>> /tools/misc/xen-mfndump.c: 401 in main()
>>> 400ÂÂÂÂÂÂÂÂ xch = xc_interface_open(0, 0, 0);
>>>>>> CID 1191885: Dereference after null check (FORWARD_NULL)
>>>>>>ÂÂÂÂ Comparing "xch" to null implies that "xch" might be null.
>>> 401ÂÂÂÂÂÂÂÂ if ( !xch )
>>> 402ÂÂÂÂÂÂÂÂ {
>>> 403ÂÂÂÂÂÂÂÂÂÂÂÂ ERROR("Failed to open an xc handler");
>>
>> This complaint is accurate. ERROR uses xch. (This is IMO not a
>> security problem.)
>>
> I think Andrew sent a patch (and its v2 also) about it already:
> http://www.gossamer-threads.com/lists/xen/devel/320397

Indeed I have - it has suitable acks and is pending committing now.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel