Re: [Xen-devel] [PATCH v5 3/5] x86/time: Initialise time earlier during start_secondary()

[Keir Fraser <keir@xxxxxxx>]

On Fri, Mar 7, 2014 at 5:28 PM, Andrew Cooper <andrew.cooper3@xxxxxxxxxx> wrote:

It is safe to do so, and useful for "[second.microseconds]" style timestamps
on printk()s during secondary bringup.

Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
CC: Keir Fraser <keir@xxxxxxx>
CC: Jan Beulich <JBeulich@xxxxxxxx>
CC: Tim Deegan <tim@xxxxxxx>

I know Jan is uncertain about this one. I also don't like moving functions around in AP bringup very much... I'm kind of on the fence with this one, but I think it's okay here.

 

Acked-by: Keir Fraser <keir@xxxxxxx>

---
 xen/arch/x86/smpboot.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/xen/arch/x86/smpboot.c b/xen/arch/x86/smpboot.c
index 42b8a59..5014397 100644
--- a/xen/arch/x86/smpboot.c
+++ b/xen/arch/x86/smpboot.c
@@ -347,6 +347,8 @@ void start_secondary(void *unused)

     percpu_traps_init();

+    init_percpu_time();
+
     cpu_init();

     smp_callin();
@@ -381,8 +383,6 @@ void start_secondary(void *unused)
     cpumask_set_cpu(cpu, &cpu_online_map);
     unlock_vector_lock();

-    init_percpu_time();
-
     /* We can take interrupts now: we're officially "up". */
     local_irq_enable();
     mtrr_ap_init();
--
1.7.10.4

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel