[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [RFC 6/6] xen/arm: Replace early_printk call to printk call



Hi Ian,

On 19/02/14 20:33, Ian Campbell wrote:
On Sun, 2014-01-05 at 21:26 +0000, Julien Grall wrote:

-/* Some device tree functions may be called both before and after the
-   console is initialized. */
-#define dt_printk(fmt, ...)                         \
-    do                                              \
-    {                                               \
-        if ( system_state == SYS_STATE_early_boot ) \
-            early_printk(fmt, ## __VA_ARGS__);      \
-        else                                        \
-            printk(fmt, ## __VA_ARGS__);            \
-    } while (0)
+#define dt_printk(fmt, ...) printk(fmt, ## __VA_ARGS__);

Since dt_printk basically existed solely as a hack to workaround the
distinction between early_printk and printk I think you could just
switch everything to printk directly.

I forgot to replace dt_printk by printk in v2. I will send another version.

Sincerely yours,


--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.