Re: [Xen-devel] [PATCH V4 net-next 2/5] xen-netback: Add support for multiple queues

[Andrew Bennieston <andrew.bennieston@xxxxxxxxxx>]

On 21/02/14 12:22, David Vrabel wrote:
> > > > +    char *xspath = NULL;
> > > I don't think you need the NULL init here. xspath is set in both
> > > branches of the if statement below.
> > Indeed, but I prefer to initialise things sanely where possible. It
> > makes it easier to spot problems with later modifications of the code,
> > e.g. if one of those branches changed.
> Kernel style (but probably not documented anywhere) is to only
> initialize locals were necessary.
>
> David
Ok, I'll remove the NULL initialiser then.

Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel