Re: [Xen-devel] [PATCH-4.5 v2 0/10] remove maintenance interrupts

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2014-02-14 at 15:50 +0000, Stefano Stabellini wrote:
> Hi all,
> this patch series removes any needs for maintenance interrupts for both
> hardware and software interrupts in Xen.

I tried this on Xgene and it fails to boot, apparently it's not seeing
any SATA interrupts (the logs are uninteresting I think, all looks like
SATA failures).

bisecting fingers:

8916c25c9f4fc0d71dc3ac5dcb28b68bf4effb4e is the first bad commit
commit 8916c25c9f4fc0d71dc3ac5dcb28b68bf4effb4e
Author: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
Date:   Wed Feb 12 17:48:10 2014 +0000

    xen/arm: support HW interrupts in gic_set_lr
    
    If the irq to be injected is an hardware irq (p->desc != NULL), set
    GICH_LR_HW.
    
    Remove the code to EOI a physical interrupt on behalf of the guest
    because it has become unnecessary.
    
    Also add a struct vcpu* parameter to gic_set_lr.
    
    Signed-off-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
    
    ---
    
    Changes in v2:
    - remove the EOI code, now unnecessary;
    - do not assume physical IRQ == virtual IRQ;
    - refactor gic_set_lr.

:040000 040000 9647c168e6e7d81fd57f70c8519d1c4bbee7d33c 
93344e9ddb4fa2da3c0e578bc3ebfbcf153ad5a1 M      xen


$ git bisect log
git bisect start
# good: [feee1ace547cf6247a358d082dd64fa762be2488] Merge branch 'master' into 
staging
git bisect good feee1ace547cf6247a358d082dd64fa762be2488
# bad: [739a2ff8910dac953c3adebddebfe621b537fab4] Merge branch 
'no_maintenance_interrupts-v2' of 
git://xenbits.xen.org/people/sstabellini/xen-unstable into no-maint-irq
git bisect bad 739a2ff8910dac953c3adebddebfe621b537fab4
# bad: [c94edf5af6962aba8840fe03529717d359781ae7] xen/arm: keep track of the 
GICH_LR used for the irq in struct pending_irq
git bisect bad c94edf5af6962aba8840fe03529717d359781ae7
# bad: [8916c25c9f4fc0d71dc3ac5dcb28b68bf4effb4e] xen/arm: support HW 
interrupts in gic_set_lr
git bisect bad 8916c25c9f4fc0d71dc3ac5dcb28b68bf4effb4e
# good: [38b0d97d407d33d9eeb26e310daf25119867a943] xen/arm: remove unused 
virtual parameter from vgic_vcpu_inject_irq
git bisect good 38b0d97d407d33d9eeb26e310daf25119867a943



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel