Re: [Xen-devel] [OSSTEST PATCH] freebsd: switch to 10.0-RELEASE (20140116-r260789)

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Roger Pau Monné writes ("Re: [OSSTEST PATCH] freebsd: switch to 10.0-RELEASE 
(20140116-r260789)"):
> On 10/02/14 13:26, Ian Jackson wrote:
> > Roger Pau Monné writes ("Re: [OSSTEST PATCH] freebsd: switch to 
> > 10.0-RELEASE (20140116-r260789)"):
> >> Thanks for the patch. I think it's missing the following chunk:
> > ...
> >> -our $freebsd_version= "10.0-BETA3";
> >> +our $freebsd_version= "10.0-RELEASE";
> > 
> > Oh.  Err, why is this hardcoded in the script ?  Changing the
> > runvar(s) ought to be sufficient.
> > 
> > ... (looks at the code) ...
> > 
> > Oh, I see, that's just the default.  Perhaps the default should be
> > removed entirely ?  None of the other scripts have a default image
> > filename.
> 
> So $freebsd_image is going to contain the absolute path to the image?
> I'm asking because ts-freebsd-install searches for the image in
> /var/images, do we have to do something like /var/images/$freebsd_image
> in order to get the absolute image path?

(Sorry for not replying sooner.)

In flights made with make-flight, the runvar $r{freebsd_image} is
always set and is used by target_put_guest_image instead of the third
"default" argument.  So both $freebsd_version and $freebsd_vm_repo are
ignored.

ts-redhat-install and ts-windows-install both use
more_prepareguest_hvm which pass "undef" for the third argument.
So I'm suggesting that the bit of ts-freebsd-install which constructs
the default image filename be removed.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel