Re: [Xen-devel] [PATCH v6 1/7] x86: detect and initialize Cache QoS Monitoring feature

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 28.01.14 at 15:01, "Xu, Dongxiao" <dongxiao.xu@xxxxxxxxx> wrote:
>>  -----Original Message-----
>> From: Jan Beulich [mailto:JBeulich@xxxxxxxx]
>> Sent: Monday, January 20, 2014 9:01 PM
>> To: Xu, Dongxiao
>> Cc: andrew.cooper3@xxxxxxxxxx; dario.faggioli@xxxxxxxxxx;
>> Ian.Campbell@xxxxxxxxxx; Ian.Jackson@xxxxxxxxxxxxx;
>> stefano.stabellini@xxxxxxxxxxxxx; xen-devel@xxxxxxxxxxxxx;
>> konrad.wilk@xxxxxxxxxx; dgdegra@xxxxxxxxxxxxx; keir@xxxxxxx 
>> Subject: Re: [PATCH v6 1/7] x86: detect and initialize Cache QoS Monitoring
>> feature
>> 
>> >>> On 05.12.13 at 10:38, Dongxiao Xu <dongxiao.xu@xxxxxxxxx> wrote:
>> > --- a/xen/arch/x86/cpu/intel.c
>> > +++ b/xen/arch/x86/cpu/intel.c
>> > @@ -230,6 +230,12 @@ static void __devinit init_intel(struct cpuinfo_x86 
>> > *c)
>> >         ( c->cpuid_level >= 0x00000006 ) &&
>> >         ( cpuid_eax(0x00000006) & (1u<<2) ) )
>> >            set_bit(X86_FEATURE_ARAT, c->x86_capability);
>> > +
>> > +  /* Check platform QoS monitoring capability */
>> > +  if ((c->cpuid_level >= 0x00000007) &&
>> > +      (cpuid_ebx(0x00000007) & (1u<<12)))
>> > +          set_bit(X86_FEATURE_QOSM, c->x86_capability);
>> > +
>> 
>> This is redundant with generic_identify() setting the respective
>> c->x86_capability[] element.
>> 
>> > +struct pqos_cqm *cqm;
>> 
>> __read_mostly?
> cqm->rmid_to_dom will be updated time to time.

But the attribute applies to the variable itself, not what it points to.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel