Re: [Xen-devel] [Patch] tools/libxc: Correct read_exact() error messages

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2014-01-07 at 10:04 +0000, Andrew Cooper wrote:
> The errors have been incorrectly identifying their function since c/s
> 861aef6e1558bebad8fc60c1c723f0706fd3ed87 which did a lot of error handling
> cleanup.
> 
> Use __func__ to ensure the name remains correct in the future.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> CC: Ian Campbell <Ian.Campbell@xxxxxxxxxx>
> CC: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>

A simple string change seems harmless from a release PoV, so on that
front 
Release-Acked-by: Ian Campbell.

For the actual change though, most uses of ERROR in this function just
have a descriptive error without the function name. If we are going to
change it then I'm not convinced "rdexact failed..." is as useful as
something like "Failed to read exactly %d bytes (select returned...)".
Other thoughts?

(that said, I'm still somewhat inclined to just bung this one in...)

Ian.

> ---
>  tools/libxc/xc_domain_restore.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/libxc/xc_domain_restore.c b/tools/libxc/xc_domain_restore.c
> index 80769a7..ca2fb51 100644
> --- a/tools/libxc/xc_domain_restore.c
> +++ b/tools/libxc/xc_domain_restore.c
> @@ -87,7 +87,7 @@ static ssize_t rdexact(xc_interface *xch, struct 
> restore_ctx *ctx,
>              if ( len == -1 && errno == EINTR )
>                  continue;
>              if ( !FD_ISSET(fd, &rfds) ) {
> -                ERROR("read_exact_timed failed (select returned %zd)", len);
> +                ERROR("%s failed (select returned %zd)", __func__, len);
>                  errno = ETIMEDOUT;
>                  return -1;
>              }
> @@ -101,7 +101,7 @@ static ssize_t rdexact(xc_interface *xch, struct 
> restore_ctx *ctx,
>              errno = 0;
>          }
>          if ( len <= 0 ) {
> -            ERROR("read_exact_timed failed (read rc: %d, errno: %d)", len, 
> errno);
> +            ERROR("%s failed (read rc: %d, errno: %d)", __func__, len, 
> errno);
>              return -1;
>          }
>          offset += len;



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel