Re: [Xen-devel] [PATCH v4 11/15] tmem: cleanup: drop useless functions from head file

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2014-01-07 at 14:44 +0000, Jan Beulich wrote:
> >>> On 07.01.14 at 15:32, Ian Campbell <Ian.Campbell@xxxxxxxxxx> wrote:
> > On Tue, 2014-01-07 at 09:27 -0500, Konrad Rzeszutek Wilk wrote:
> >> On Tue, Jan 07, 2014 at 06:44:51PM +0800, Bob Liu wrote:
> >> > 
> >> > On 12/14/2013 12:44 AM, Konrad Rzeszutek Wilk wrote:
> >> > > On Thu, Dec 12, 2013 at 07:05:11PM +0800, Bob Liu wrote:
> >> > >> They are several one line functions in tmem_xen.h which are useless, 
> >> > >> this 
> > patch
> >> > >> embeded them into tmem.c directly.
> >> > >> Also modify void *tmem in struct domain to struct client *tmem_client 
> >> > >> in 
> > order
> >> > >> to make things more straightforward.
> >> > >>
> >> > >> Signed-off-by: Bob Liu <bob.liu@xxxxxxxxxx>
> >> > >> ---
> >> > >>  xen/common/domain.c        |    4 ++--
> >> > >>  xen/common/tmem.c          |   24 ++++++++++++------------
> >> > >>  xen/include/xen/sched.h    |    2 +-
> >> > >>  xen/include/xen/tmem_xen.h |   30 +-----------------------------
> >> > > 
> >> > > Keir, are you OK with this simple name change?
> >> > > 
> >> > 
> >> > Ping..
> >> 
> >> Lets make sure his email is on the 'To' (I don't see it
> >> in my email?)
> > 
> > I haven't reviewed the patch or anything but it says "cleanup" -- I
> > think we are past that point of the release process, aren't we?
> 
> It has been pending for quite a while, and tmem isn't critical code,
> so I would tend towards taking it if we can get Keir's ack (if there
> wasn't that relatively trivial change to common code, I would have
> pulled the set already).

OK, I'm happy to follow your lead on that decision.

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel