Re: [Xen-devel] conflict in public header for values definitions

[Igor Kozhukhov <ikozhukhov@xxxxxxxxx>]

Hi Andrew,

it is impossible to do outside public headers, because we have trace.h included 
to another public readers - for example: xen/public/hvm/hvm_op.h

will be better to have committed changes in public headers for next ports 
without additional changes in sources.

is it possible to add '#ifdef __sun' to public headers ?
I can try to do it and provide review ?
or i need update public headers in illumos tree every time ?

--
Best regards,
Igor Kozhukhov




On Jan 3, 2014, at 10:43 PM, Andrew Cooper wrote:

> On 03/01/14 18:38, Igor Kozhukhov wrote:
>> Hello All,
>> 
>> I'm working on port xen-4.2 to illumos based platform - DilOS - and have 
>> problems with conflicts for:
>> 
>> xen/include/public/trace.h :
>> 
>> struct t_buf {}
>> struct t_info {}
>> 
>> I have a questions - can we rename structures to:
>> struct t_buf_xen {}
>> struct t_info_xen {}
>> 
>> Will it be applicable for Xen sources ?
> 
> You would break the compilation for every other user of trace.h, so no.
> 
> If it conflicts with something locally, you could do something like:
> (completely untested)
> 
> #define t_buf t_buf_xen
> #include <public/trace.h>
> #undef t_buf
> 
> And use t_buf_xen in your own code.
> 
> ~Andrew
> 


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel