[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v2] xen: arm: process XENMEM_add_to_physmap_range forwards not backwards.



>>> On 18.12.13 at 15:37, Ian Campbell <Ian.Campbell@xxxxxxxxxx> wrote:
> On Wed, 2013-12-18 at 14:08 +0000, Jan Beulich wrote:
>> >>> On 18.12.13 at 14:39, Ian Campbell <ian.campbell@xxxxxxxxxx> wrote:
>> > Jan points out that processing the list backwards is rather counter 
> intuitive
>> > and that the effect of the hypercall can differ between forwards and 
>> > backwards
>> > processing (e.g. in the presence of duplicate idx or gpfn, which would be
>> > unusualy but as Jan says, users are a creative bunch)
>> > 
>> > Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
>> 
>> Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
> 
> Thanks. I've applied without waiting for a further ARM maintainer ack
> since the nature of the change is not really specifc to arm
> 
> (I fixed the "unusualy" typo I spotted above as I went).
> 
> Just to confirm -- Are you going to make this not writeback its params
> while you fix the x86 equivalent? I can take a look if not.

You've seen the patches meanwhile I guess - the answer is yes,
but by way of making the framework code common rather than
fixing it in both ARM and x86 separately.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.