Re: [Xen-devel] [PATCH v11 11/12] xen/pvh: Disable PV code that does not work with PVH.

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Tue, 17 Dec 2013, Konrad Rzeszutek Wilk wrote:
> From: Mukesh Rathor <mukesh.rathor@xxxxxxxxxx>
> 
> As we do not have yet a mechanism for that.
> 
> Signed-off-by: Mukesh Rathor <mukesh.rathor@xxxxxxxxxx>
> Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>

Even though we don't even compile cpu_hotplug on ARM yet, I don't like
this change because it affects ARM guests too.

Please add a note about ARM guests in the FIXME line.


>  drivers/xen/cpu_hotplug.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/xen/cpu_hotplug.c b/drivers/xen/cpu_hotplug.c
> index cc6513a..cbb02af 100644
> --- a/drivers/xen/cpu_hotplug.c
> +++ b/drivers/xen/cpu_hotplug.c
> @@ -4,6 +4,7 @@
>  
>  #include <xen/xen.h>
>  #include <xen/xenbus.h>
> +#include <xen/features.h>
>  
>  #include <asm/xen/hypervisor.h>
>  #include <asm/cpu.h>
> @@ -102,7 +103,8 @@ static int __init setup_vcpu_hotplug_event(void)
>       static struct notifier_block xsn_cpu = {
>               .notifier_call = setup_cpu_watcher };
>  
> -     if (!xen_pv_domain())
> +     /* PVH TBD/FIXME: future work */
> +     if (!xen_pv_domain() || xen_feature(XENFEAT_auto_translated_physmap))
>               return -ENODEV;
>  
>       register_xenstore_notifier(&xsn_cpu);


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel