Re: [Xen-devel] [PATCH] xen: Pass the location of the ACPI RSDP to DOM0.

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 17/12/13 19:09, Philip Wernersbach wrote:
> I can't post patches inline because my mail client corrupts the
> patches with extra white space. The linked patch should meet all
> requirements listed in Submitting_Xen_Patches.
>
> Thanks,
> Philip Wernersbach

In which case I shall do a cursory review right now.

You have used tabs not spaces.  This needs fixing, and will likely fix
the alignment issues

"static acpi_physical_address __initdata global_rsdp_address;" should
not be static.  As the patch currently stands you have two static
variables with same name.

"static char __initdata global_rsdp_address_string" again shouldn't be
static

acpi_os_get_root_pointer() already a global function which does what you
want.  No need to edit drivers/acpi/tables at all.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel