Re: [Xen-devel] [xen-unstable test] 22451: tolerable FAIL

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2013-12-17 at 14:57 +0000, Ian Jackson wrote:
> Ian Campbell writes ("Re: [Xen-devel] [xen-unstable test] 22451: tolerable 
> FAIL"):
> > On Tue, 2013-12-17 at 11:08 +0000, xen.org wrote:
> > >  test-armhf-armhf-xl           8 debian-fixup                 fail   
> > > never pass
> > 
> > Progress!
> > 
> > This is failing with[0]:
> >         scp: /etc/xen/debian.guest.osstest.cfg: No such file or
> >         directory
> > which is bogus because the actual failure was on the previous
> > debian-install step which failed with:
> >         2013-12-17 05:35:24 Z executing ssh ... root@xxxxxxxxxxxxx         
> > xen-create-image \
> >                     --dhcp --mac 5a:36:0e:b3:00:0a \
> >                     --memory 512Mb --swap 1000Mb \
> ...
> 
> Looking at the code in ts-debian-install, I think the error handling
> failure is in xen-create-image and not osstest.  The shell command
> which is being run has only that one command in it, so the lack of
> set -e is not relevant.

That was my conclusion also.

> > I don't know if osstest is buggy for failing to catch this or if
> > xen-create-image is buggily returning success (it's a Perl "die" so I
> > suspect osstest is to blame).
> 
> I can't explain this.  Perhaps it runs some other program as a
> subprocess and doesn't trap the error.

Maybe.

> > Apart from the error handling failure, what to do about the actual
> > error? Obviously I should file a bug against xen-create-image asking it
> > to not rely on xend being installed but in the meantime shall patch
> > osstest to add a dummy version of this file? The alternative would be to
> > patch xen-create-image on the rootfs which is pretty gross.
> 
> I think creating the empty file is the only reasonable thing to do in
> osstest.

Right :-/ I'll cook up a patch.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel