Re: [Xen-devel] [PATCH V3] xl: create VFB for PV guest when VNC is specified

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Ian Campbell writes ("Re: [PATCH V3] xl: create VFB for PV guest when VNC is 
specified"):
> On Mon, 2013-12-16 at 17:39 +0000, Wei Liu wrote:
> > +        (count) = (count) + 1;                                          \
> 
> (count++)

You mean
  (count)++

> I suppose in a macro like this it is tricky to arrange to only evaluate
> the arguments once, since you need to read and write, but I think you
> can arrange to evaluate array exactly once instead of 3 times and count
> just once.

I think it is fine for a macro to evaluate its arguments as many times
as it feels like.  That's one thing the SHOUTING is there to warn yo
about.

I agree with the rest of Ian C's comments.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel