Re: [Xen-devel] [PATCH] xl: create VFB for PV guest when VNC is specified

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Ian Campbell writes ("Re: [PATCH] xl: create VFB for PV guest when VNC is 
specified"):
> I think what Ian was suggesting was a single macro which could expand an
> arbitrary array given as a parameter, rather than this, which is pretty
> fuggly. e.g.
>       vfb = ARRAY_EXTEND(d_config->vfbs, d_config->num_vfbs)
> or something (making liberal use of typeof() etc). Perhaps even
>                 vfb = ARRAY_EXTEND(d_config, vfbs)
> and some cpp token pasting.

Exactly.

> Once you have that you can use it for both vkb and vfb.
> 
> I think you would be better off skipping the ->devid set, but if you
> want to keep it you'd want to call it something more suitable like
> NEW_DEVICE() perhaps.
> 
> You don't need to use the new macro everywhere right now during code
> freeze but we can flip everything in 4.5.

Right.

> > @@ -1608,6 +1624,47 @@ skip_vfb:
> >  
> >  #undef parse_extra_args
> >  
> > +#define parse_top_level_vnc_options(enable,listen,passwd,display,unused) \
> 
> I think this could be a function, which is would be preferable to a
> macro if possible.

Absolutely.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel