Re: [Xen-devel] [PATCH 2/5] IOMMU: make page table deallocation preemptible

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 11.12.13 at 20:01, Andrew Cooper <andrew.cooper3@xxxxxxxxxx> wrote:
> On 10/12/2013 15:46, Jan Beulich wrote:
>> This too can take an arbitrary amount of time.
>>
>> In fact, the bulk of the work is being moved to a tasklet, as handling
>> the necessary preemption logic in line seems close to impossible given
>> that the teardown may also be invoked on error paths.
>>
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> 
> There is a lot of duplicated code here.  I would suggest making most of
> this infrastructure common, and having a new iommu_op for "void
> free_io_page_table(struct page_info*);"

I guess that could be done - let me see how this works out.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel