Re: [Xen-devel] [PATCH 01/13] libxl: fix unsigned less-than-0 comparison in e820_sanitize

[Matthew Daley <mattd@xxxxxxxxxxx>]

Ping?

On Sun, Dec 1, 2013 at 11:14 PM, Matthew Daley <mattd@xxxxxxxxxxx> wrote:
> Both src[i].size and delta are unsigned, so checking their difference
> for being less than 0 doesn't work.
>
> Coverity-ID: 1055615
> Signed-off-by: Matthew Daley <mattd@xxxxxxxxxxx>
> ---
>  tools/libxl/libxl_x86.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/libxl/libxl_x86.c b/tools/libxl/libxl_x86.c
> index e1c183f..b11d036 100644
> --- a/tools/libxl/libxl_x86.c
> +++ b/tools/libxl/libxl_x86.c
> @@ -125,7 +125,7 @@ static int e820_sanitize(libxl_ctx *ctx, struct e820entry 
> src[],
>              src[i].type = E820_UNUSABLE;
>              delta = ram_end - src[i].addr;
>              /* The end < ram_end should weed this out */
> -            if (src[i].size - delta < 0)
> +            if (src[i].size < delta)
>                  src[i].type = 0;
>              else {
>                  src[i].size -= delta;
> --
> 1.7.10.4
>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel