Re: [Xen-devel] [PATCH v2] tools: libxc: flush data cache after loading images into guest memory

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Ian Campbell writes ("Re: [PATCH v2] tools: libxc: flush data cache after 
loading images into guest memory"):
> These are all the ones I know of/could find in the domain building case,
> which is the main time we access guest memory like this, and the one
> which is problematic because the guest starts with its caches turned
> off. This is where we have an actual problem in practice today.

I'm reassured, thanks.

> > That appears to just print a warning message to a file no-one will
> > read.  I think it should crash.
> 
> Actually, for minios there is no PERROR defined at all so it won't
> compile, I clearly forgot to build test stubdoms.

Heh.

> The rest of xc_minios.c just uses printf, so I will do the same. I find
> it hard to believe that whoever is developing a minios based builder on
> ARM or some new platform wouldn't be looking at the stubdom console.
> Unless you feel strongly that I should stick an abort() in here (not
> sure what minios will do with that...).

Well, I would prefer an abort() in all of these cases.  (Not just the
minios one.)  It seems to me that it's better for the code to crash
than to carry on and do something which probably has undefined
behaviour!

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel