Re: [Xen-devel] [PATCH RFC V2 4/6] Introduce ts-ovmf-debian-install

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Thu, Dec 12, 2013 at 03:40:58PM +0000, Ian Jackson wrote:
> Wei Liu writes ("[PATCH RFC V2 4/6] Introduce ts-ovmf-debian-install"):
> > This is OVMF guest test case. It resembles ts-redhat-install:
> 
> Thanks.  This is coming along but it still has too much clone-and-hack
> in it.  All duplicated code should be factored out into TestSupport.pm
> or Debian.pm.
> 
> > +    $preseed_file .= (<<END);
> > +d-i netcfg/get_hostname string debian-hvm
> 
> This string should presumably be the guest ident or something.
> 
> > +d-i apt-setup/use_mirror boolean false
> 
> I think you need to use the mirror as specified for host installs, so
> I think you need to move the mirror stuff into preseed_base.
> 
> > +d-i pkgsel/include string openssh-server, ntp, ntpdate, 
> 
> This is mostly common with preseed_create, so should be there.  You
> will probably need to pass the xopts to preseed_base.
> 
> > +d-i preseed/early_command string
> > +
> > +d-i preseed/late_command string \\
> > +   in-target mkdir -p /boot/efi/EFI/boot; \\
> > +   in-target cp /boot/efi/EFI/debian/grubx64.efi 
> > /boot/efi/EFI/boot/bootx64.efi ;\\
> 
> Yuk.
> 
> > +   in-target mkdir -p /root/.ssh; \\
> > +        cp /authorized_keys /target/root/.ssh
> 
> There's already machinery for doing this (rather differently) in
> preseed-create.  Surely you should use it ?
> 

Using the web infrastructure for this looks overkill. I've replaced this
part with a call to 'echo -e $authkeys > authorized_keys', elimiating
the need for extra file.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel