Re: [Xen-devel] [PATCH 4 of 4 V5] tools/xl: Remus - Network buffering cmdline switch

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Shriram Rajagopalan writes ("Re: [PATCH 4 of 4 V5] tools/xl: Remus - Network 
buffering cmdline switch"):
> On Mon, Nov 25, 2013 at 7:37 AM, Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx> 
> wrote:
>     Shriram Rajagopalan writes ("[PATCH 4 of 4 V5] tools/xl: Remus - Network
>     buffering cmdline switch"):
>     > tools/xl: Remus - Network buffering cmdline switch
...
>     Shouldn't enabling network buffering be the default ?
>

> Given that network buffering support is conditionally compiled into
> libxl, it makes sense to let the user explicitly enable network
> buffering.  If network buffering was enabled by default, but libxl
> was missing the feature, then running xl remus (without any option)
> would immediately fail saying network buffering support is
> missing. Might as well make people enable it explicitly and then
> discover the lack of support for it inside libxl.

Is Remus actually useable without network buffering ?  I don't think
we would want to change the default later, and clearly the default
should be to behave correctly.

>     Is it really useful to have a command-line option to change the script ?
> 
> That was added on Ian C's suggestion. It might be useful if people have 
> openvswitch based setups and want to tweak the network buffering setup.

I think this should be a per-vif configuration option, with a default
taken from the domain and/or global config.  Not a command-line
option.

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel