Re: [Xen-devel] [PATCH 4 of 4 V5] tools/xl: Remus - Network buffering cmdline switch

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Wed, 2013-12-11 at 21:45 -0800, Shriram Rajagopalan wrote:
> On Mon, Nov 25, 2013 at 7:37 AM, Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx> 
> wrote:
>         Shriram Rajagopalan writes ("[PATCH 4 of 4 V5] tools/xl: Remus - 
> Network buffering cmdline switch"):
>         > tools/xl: Remus - Network buffering cmdline switch
>         >
>         > Command line switch to 'xl remus' command, to enable network 
> buffering.
>         > Pass on this flag to libxl so that it can act accordingly.
>         > Also update man pages to reflect the addition of a new option to
>         > 'xl remus' command.

>         Shouldn't enabling network buffering be the default ?

> Given that network buffering support is conditionally compiled into
> libxl, it makes sense to let the user explicitly enable network buffering.
> If network buffering was enabled by default, but libxl was missing the 
> feature,
> then running xl remus (without any option) would immediately fail saying 
> network 
> buffering support is missing. Might as well make people enable it explicitly 
> and 
> then discover the lack of support for it inside libxl. 

The default should be set depending on whether support was enabled in
libxl or not. libxl_defbool is the mechanism which allows this sort of
thing to be decided at the library level.

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel