Re: [Xen-devel] [PATCH v3 09/15] tmem: cleanup: drop tmem_lock_all

[Bob Liu <bob.liu@xxxxxxxxxx>]

On 12/11/2013 06:45 PM, Andrew Cooper wrote:
> On 11/12/13 08:50, Bob Liu wrote:
>> tmem_lock_all is used for debug only, remove it from upstream to make
>> tmem source code more readable and easier to maintain.
>> And no_evict is meaningless without tmem_lock_all, this patch removes it
>> also.
>>
>> Signed-off-by: Bob Liu <bob.liu@xxxxxxxxxx>
> 
> This should probably be tagged with Coverity ID 1055654 which is a
> locking order reversal between tmem_spinlock and the heap_lock.
> 

Then it would be better if it gets merged into 4.4.
By the way where I can find the full CIDs descriptions?

I remember your mentioned another issue.
------------------------------------
The two 'new' issues are both to do with:

static inline void tmem_copy_to_client_buf_offset(tmem_cli_va_param_t
clibuf, int off, char *tmembuf, int len)
{
    copy_to_guest_offset(clibuf,off,tmembuf,len);
}

Which throws away important errors which should not be ignored.
-----------------------------------

One of my patches can fix it also.

> I certainly think this is an appropriate fix.
> 

So I'll separate patches which are suitable for 4.4 from this patchset
and resend them with CIDs in the commit message.

Thanks,
-Bod

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel