Re: [Xen-devel] [PATCH v2 6/6] xen/arm: disable a physical IRQ when the guest disables the corresponding IRQ

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2013-12-10 at 18:36 +0000, Stefano Stabellini wrote:
> On Tue, 10 Dec 2013, Ian Campbell wrote:
> > On Tue, 2013-12-10 at 13:06 +0000, Stefano Stabellini wrote:
> > > Signed-off-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
> > 
> > Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> > 
> > > Changes in v2:
> > > - disable IRQs that were previously disabled.
> > 
> > These should be after a "---" marker, you've done this wrong
> > consistently in this series.
>  
> Unfortunately guilt doesn't support it. The content I write after "---"
> would get lost.

I suppose guilt uses the same tool as git am to actual apply the patches
on push, so it trims the comments too :-(

> I have the same problem with patch series I send to QEMU and Linux.
> I can either do what I have been doing or avoid writing the log on each
> patch and limiting myself to writing the log to patch #0.
> So far I have been keeping the log as part of the commit messages.

Sounds like a pretty major shortcoming of the tool TBH, perhaps time to
investigate alternatives?

Perhaps git smudge/clean filters could be used such that some other
string is ("--- CUT ME"?) stored in .git/guilt/patches/blah and is
converted on push/refresh etc to ---?

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel