Re: [Xen-devel] [V6 PATCH 6.2/7] pvh dom0: Add and remove foreign pages

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 11.12.13 at 02:47, Mukesh Rathor <mukesh.rathor@xxxxxxxxxx> wrote:
> On Wed, 11 Dec 2013 01:35:08 +0000
> Julien Grall <julien.grall@xxxxxxxxxx> wrote:
> 
>> >       unsigned long mfn = gmfn_to_mfn(d, gfn);
>> >
>> > -    ASSERT(t == NULL);
>> > +    ASSERT(*t == INT_MAX);
>> 
>> There is various place where get_page_from_gfn where t == NULL. With 
>> this solution it will segfault every time.
>> 
>> I would do something like that:
>>    if (*t)
>>      t = INT_MAX;
>...
> @@ -83,7 +83,8 @@ static inline struct page_info *get_page_from_gfn(
>      struct page_info *page;
>      unsigned long mfn = gmfn_to_mfn(d, gfn);
>  
> -    ASSERT(t == NULL);
> +    if ( t )
> +        ASSERT(*t == INT_MAX);

If you already don't follow Julien's suggestion, then please

    ASSERT(!t || *t == INT_MAX);

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel