Re: [Xen-devel] [PATCH v6 08/11] libxl: ocaml: drop the ocaml heap lock before calling into libxl

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2013-12-10 at 14:51 +0000, Rob Hoes wrote:
> > Can you remind me why this needs to be dynamically allocated please,
> > preferably by adding the explanation to the commit message.
> 
> It doesn't need to be. It just made the function a little nicer to use
> (to me). I appreciate that C-experts may have better ways of doing
> this :)

OK, I suppose there is no need to respin for this then, perhaps just
mention in the commit message that the aohow is being changed to be
dynamically allocated because you think it is a better API. (unexplained
changes in patches tend to make people twitchy, and are confusing as
hell in 6 months time...)

Ian


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel