Re: [Xen-devel] [PATCH] tools: libxl: testidl: initialise the KeyedUnion keyvar before the union

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Ian Campbell writes ("Re: [PATCH] tools: libxl: testidl: initialise the 
KeyedUnion keyvar before the union"):
> On Wed, 2013-12-04 at 17:54 +0000, Andrew Cooper wrote:
> > This sound plausible, although given my unfamiliarity with gentest.py, I
> > dont feel as if a Reviewed-by tag is appropriate.
> 
> FWIW, if I insert a random.random() at the same place (to account for
> the new call to random to be introduced, which knocks all the subsequent
> values "down one") and then compare the result of that with the output
> of this patch (with LIBXL_TESTIDL_SEED=42 in both cases) the diff is:

I did try to review this, but I wasn't sure how to do that random
alignment trick and then I saw you'd applied it.

> Since this is a) not critical code by any stretch and b) not something I
> expect anyone is going to review, I've just applied it.

Fair enough.

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel