Re: [Xen-devel] [PATCH v2 04/10] xen/arm: Store p2m type in each page of the guest

[Julien Grall <julien.grall@xxxxxxxxxx>]

On 12/09/2013 04:53 PM, Ian Campbell wrote:
> On Mon, 2013-12-09 at 03:34 +0000, Julien Grall wrote:
> > +    BUILD_BUG_ON(p2m_max_real_type > (2 << 4));
> 2<<4 is 32.
>
> I think you want either 1<<4, 2^4 or just 16 (my preference is 16). And
Right.

> I think it should be >= since the valid values are 0..15 inclusive.
No, because p2m_max_real_type won't be store in the p2m, so we can have 
16 values [0..15] and p2m_max_real_type will be the 17th (ie 16).
--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel